feat(flagd): Context value hydration#195
Merged
beeme1mr merged 3 commits intoopen-feature:mainfrom Mar 5, 2025
Merged
Conversation
beeme1mr
reviewed
Feb 18, 2025
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/provider.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 94.13% 94.28% +0.15%
==========================================
Files 17 18 +1
Lines 903 928 +25
==========================================
+ Hits 850 875 +25
Misses 53 53 ☔ View full report in Codecov by Sentry. |
aepfli
force-pushed
the
feat/context-value-hydration
branch
7 times, most recently
from
cf51d68 to
596c22e
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/context-value-hydration
branch
from
596c22e to
a5af90e
Compare
toddbaert
approved these changes
Feb 27, 2025
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
Approving but consider the my comment.
chrfwow
approved these changes
Feb 28, 2025
aepfli
force-pushed
the
feat/context-value-hydration
branch
from
9431d23 to
dceff15
Compare
beeme1mr
approved these changes
Mar 4, 2025
aepfli
force-pushed
the
feat/context-value-hydration
branch
from
dceff15 to
6fef4af
Compare
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
force-pushed
the
feat/context-value-hydration
branch
from
6fef4af to
1d46ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds context value hydration to the in-process evaluator.
This means, that flagd will provide contextual attributes on connection startup which will be used for inprocess evaluation, like defined in the spec.
https://flagd.dev/reference/specifications/providers/#sync-metadata-properties-in-the-evaluation-context
Follow-up: